netdev - Re: [PATCH v2 net-next] mdio_bus: Fix PTR_ERR() usage after initialization to constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190218.163610.648449069622071841.davem@davemloft.net>
Date:   Mon, 18 Feb 2019 16:36:10 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] mdio_bus: Fix PTR_ERR() usage after
 initialization to constant

From: YueHaibing <yuehaibing@...wei.com>
Date: Sat, 16 Feb 2019 10:59:35 +0800

> Fix coccinelle warning:
> 
> ./drivers/net/phy/mdio_bus.c:51:5-12: ERROR: PTR_ERR applied after initialization to constant on line 44
> ./drivers/net/phy/mdio_bus.c:52:5-12: ERROR: PTR_ERR applied after initialization to constant on line 44
> 
> fix this by using IS_ERR before PTR_ERR
> 
> Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: remove variable 'ret'

Applied.