netdev - Re: [PATCH ipsec] xfrm: Fix inbound traffic via XFRM interfaces across network namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190219060418.GP3087@gauss3.secunet.de>
Date:   Tue, 19 Feb 2019 07:04:18 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Tobias Brunner <tobias@...ongswan.org>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec] xfrm: Fix inbound traffic via XFRM interfaces
 across network namespaces

On Mon, Feb 18, 2019 at 10:49:39AM +0100, Tobias Brunner wrote:
> After moving an XFRM interface to another namespace it stays associated
> with the original namespace (net in `struct xfrm_if` and the list keyed
> with `xfrmi_net_id`), allowing processes in the new namespace to use
> SAs/policies that were created in the original namespace.  For instance,
> this allows a keying daemon in one namespace to establish IPsec SAs for
> other namespaces without processes there having access to the keys or IKE
> credentials.
> 
> This worked fine for outbound traffic, however, for inbound traffic the
> lookup for the interfaces and the policies used the incorrect namespace
> (the one the XFRM interface was moved to).
> 
> Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
> Signed-off-by: Tobias Brunner <tobias@...ongswan.org>

Applied, thanks a lot Tobias!