netdev - Re: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Feb 2019 09:51:29 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     "Saleem, Shiraz" <shiraz.saleem@...el.com>
Cc:     "dledford@...hat.com" <dledford@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: Re: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs

On Wed, Feb 20, 2019 at 02:52:31PM +0000, Saleem, Shiraz wrote:

> >All lists of things should be sorted. I saw many examples of unsorted lists.
> 
> OK. We weren't aware of this rule in kernel drivers. Is this subsystem specific?

It is a general kernel preference - it helps avoid unnecessary merge
conflicts. Lists in kconfig, makefiles, etc should all be
sorted. Other order-independent lists, like ops, and what not should
be sorted for the same reasons.

> >> +	iwibdev->ibdev.iwcm->add_ref = irdma_add_ref;
> >> +	iwibdev->ibdev.iwcm->rem_ref = irdma_rem_ref;
> >> +	iwibdev->ibdev.iwcm->get_qp = irdma_get_qp;
> >> +	iwibdev->ibdev.iwcm->connect = irdma_connect;
> >> +	iwibdev->ibdev.iwcm->accept = irdma_accept;
> >> +	iwibdev->ibdev.iwcm->reject = irdma_reject;
> >> +	iwibdev->ibdev.iwcm->create_listen = irdma_create_listen;
> >> +	iwibdev->ibdev.iwcm->destroy_listen = irdma_destroy_listen;
> >
> >Huh. These should probably be moved into the ops structure too.
> 
> Not sure. It looks cleaner this way. These are iWARP CM
> specific. Why allocate them for all devices?

Not sure a few bytes really matter.

Jason