netdev - Re: [RFC PATCH net-next v3 08/21] ethtool: generic handlers for GET requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 18:42:46 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...nulli.us>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next v3 08/21] ethtool: generic handlers for GET
 requests

On Mon, 18 Feb 2019 19:22:04 +0100 (CET), Michal Kubecek wrote:
> +static struct common_req_info *alloc_get_data(const struct get_request_ops *ops)

nit: IMHO prefixing all structures and functions with a common phrase
     (ethnl) makes the code easier to navigate.

> +{
> +	struct common_req_info *req_info = kmalloc(ops->data_size, GFP_KERNEL);
> +
> +	if (!req_info)
> +		return NULL;

nit: please avoid calling complex functions inline, especially if the
     result has to be error checked