netdev - Re: mlx5 stable backport help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7aa52a751ed2e2a77fa05df23ecad4444f66387.camel@mellanox.com>
Date:   Thu, 21 Feb 2019 00:43:13 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: mlx5 stable backport help

On Wed, 2019-02-20 at 16:21 -0800, David Miller wrote:
> From: Saeed Mahameed <saeedm@...lanox.com>
> Date: Wed, 20 Feb 2019 23:58:12 +0000
> 
> > Maybe you have some git config which fails on the warning i saw.. 
> 
> Put the actual commit into a patch using "git format-patch" then try
> to use "git am" to apply it.
> 
> I'm not doing anything fancy.

I see, for some reason cherry-pick is happy to resolve the conflict
without human help.

Anyway the conflict is really simple and contextual, 2 hunks will fail

1) adding a new filed "max_mod_hdr_actions" to "struct
mlx5e_tc_flow_parse_attr"

2) at parse_tc_pedit_action() line 1924 :
replace:
-       err = alloc_mod_hdr_actions(priv, a, namespace, parse_attr);
-       if (err)
-               goto out_err;

with:
+       if (!parse_attr->mod_hdr_actions) {
+               err = alloc_mod_hdr_actions(priv, a, namespace,
parse_attr);
+               if (err)
+                       goto out_err;
+       }

all in drivers/net/ethernet/mellanox/mlx5/core/en_tc.c file
they fail since the surrounding code is slightly different.