netdev - Re: [PATCH v2 iproute2-next 07/11] devlink: Add devlink health diagnose command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221142846.GQ2312@nanopsycho>
Date:   Thu, 21 Feb 2019 15:28:46 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Aya Levin <ayal@...lanox.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>
Subject: Re: [PATCH v2 iproute2-next 07/11] devlink: Add devlink health
 diagnose command

Thu, Feb 21, 2019 at 02:42:43PM CET, ayal@...lanox.com wrote:
>Add devlink health diagnose command: enabling retrieval of diagnostics data
>by the user on a reporter on a device. The command's output is a
>free text defined by the reporter.
>
>This patch also introduces an infra structure for flexible format
>output. This allow the  command to display different data fields
>according to the reporter.
>Example:
>$ devlink health diagnose pci/0000:00:0a.0 reporter tx
>SQs:
>  sqn: 4403 HW state: 1 stopped: false
>  sqn: 4408 HW state: 1 stopped: false
>  sqn: 4413 HW state: 1 stopped: false
>  sqn: 4418 HW state: 1 stopped: false
>  sqn: 4423 HW state: 1 stopped: false
>
>$ devlink health diagnose pci/0000:00:0a.0 reporter tx -jp
>{
> "SQs":[
>      {
>       "sqn":4403,
>       "HW state":1,
>       "stopped":false
>     },
>      {
>       "sqn":4408,
>       "HW state":1,
>       "stopped":false
>     },
>      {
>       "sqn":4413,
>       "HW state":1,
>       "stopped":false
>     },
>      {
>       "sqn":4418,
>       "HW state":1,
>       "stopped":false
>     },
>      {
>       "sqn":4423,
>       "HW state":1,
>       "stopped":false
>     }
>   ]
>}
>
>Signed-off-by: Aya Levin <ayal@...lanox.com>
>Reviewed-by: Moshe Shemesh <moshe@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>