netdev - Re: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6f27ca0-55d6-4d3b-e498-ed700eb00844@gmail.com>
Date:   Thu, 21 Feb 2019 10:23:01 -0500
From:   David Ahern <dsahern@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Leon Romanovsky <leonro@...lanox.com>,
        netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code

On 2/20/19 2:21 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...lanox.com>
> 
> There is no need to keep same print functions for
> uint32_t and uint64_t, unify them into one function.
> 
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> ---
>  rdma/res.c | 22 +++++++---------------
>  1 file changed, 7 insertions(+), 15 deletions(-)
> 
> diff --git a/rdma/res.c b/rdma/res.c
> index 6b0f5fe3..87865ec8 100644
> --- a/rdma/res.c
> +++ b/rdma/res.c
> @@ -808,28 +808,20 @@ static int res_cq_parse_cb(const struct nlmsghdr *nlh, void *data)
>  	return MNL_CB_OK;
>  }
>  
> -static void print_key(struct rd *rd, const char *name, uint32_t val)
> +static void print_key(struct rd *rd, const char *name, uint64_t val)
>  {
>  	if (rd->json_output)
>  		jsonw_xint_field(rd->jw, name, val);
>  	else
> -		pr_out("%s 0x%x ", name, val);
> +		pr_out("%s 0x%" PRIx64 " ", name, val);
>  }

what's the plan to move rdma tool to iproute2's json functions?

I realize rdma tool inherited this from devlink, but this command does
not need to continue managing this.