netdev - Re: [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMjUc93sYnCKBBmno_uxJ81UtqYDTtmMZzP=yzaGynz0Qg@mail.gmail.com>
Date:   Thu, 21 Feb 2019 18:26:51 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Tonghao Zhang <xiangxia.m.yue@...il.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify
 header action zero

On Thu, Feb 21, 2019 at 3:42 PM <xiangxia.m.yue@...il.com> wrote:
>         else /* namespace is MLX5_FLOW_NAMESPACE_KERNEL - NIC offloading */
>                 max_actions = MLX5_CAP_FLOWTABLE_NIC_RX(priv->mdev, max_modify_header_actions);
>
> +       if (!max_actions) {
> +               NL_SET_ERR_MSG_MOD(extack,
> +                                  "don't support pedit actions, can't offload");
> +               netdev_warn(priv->netdev, "don't support pedit actions, can't offload\n");

it's not going to work if we keep filling the driver with duplicated
error messages, stick to extack only

Also, when you respin with comments provided on this submission,
please send also cover letter
which is  going to be "[PATCH net-next 00/05] ... "  use
--cover-letter for git format-patch and edit it after creation