netdev - Re: stmmac / meson8b-dwmac

Open Source and information security mailing list archives

Message-ID: <9074d29b-4cc9-87b6-009f-48280a4692c0@gmx.de>
Date:   Thu, 21 Feb 2019 18:27:41 +0100
From:   Simon Huelck <simonmail@....de>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Jose Abreu <jose.abreu@...opsys.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     linux-amlogic@...ts.infradead.org, netdev@...r.kernel.org,
        alexandre.torgue@...com,
        Emiliano Ingrassia <ingrassia@...genesys.com>,
        Gpeppe.cavallaro@...com
Subject: Re: stmmac / meson8b-dwmac

Am 21.02.2019 um 15:21 schrieb Jerome Brunet:
> On Tue, 2019-02-19 at 20:41 +0100, Simon Huelck wrote:
>> Am 19.02.2019 um 09:47 schrieb Jose Abreu:
>>> Hi Simon,
>>>
>>> On 2/18/2019 6:05 PM, Simon Huelck wrote:
>>>> disabling EEE doesnt help ( did it via the entry in the .dtb / .dts ),
>>>> the results are the same. I can confirm the LPI counters are zero or one
>>>> only after the test.....
>>> It's interesting to see that you have a lot of RX packets but few
>>> RX interrupts. This can either be due to mis-configuration of
>>> interrupt flags or RX Watchdog.
>>>
>>> 1. For interrupt flags you should be using LEVEL triggered IRQ.
>>> 2. For RX Watchdog you can try disabling it by adding the
>>> following in your platform wrapper driver (which will be
>>> "dwmac-meson8b.c", at probe):
>>> 	"plat_data->force_sf_dma_mode = 1;" and
>>> 	"plat_data->riwt_off = 1;"
>>>
>>> Thanks,
>>> Jose Miguel Abreu
>> Hi,
>>
>>
>> are you aware that odroid c2 dts is using level irq ?
> The odroid-c2 (meson-gxl) is using level triggered irq, indeed.
> For a reason that still eludes me, The odroid-c1 (meson8b) isn't.
>
> This is confusing since both boards have been mentionned in this thread.
>
>> at which numbers do you estimage that RX irqs are low in numbers ?
>>
>>
>> regards,
>>
>> Simon
>>
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
Hi,

this was changed recently, with a patch for the EEE stuff , see here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.0-rc7&id=e35e26b26e955c53e61c154ba26b9bb15da6b858

before that the IRQ stuff was differently. I tried to revert this patch
via git locally, but had no success ( i guess git tried to revert this
patch on the server :-P)

regards,

Simon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives