netdev - Re: [PATCH net] net: avoid false positives in untrusted gso validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190221.140849.2117139861357774917.davem@davemloft.net>
Date:   Thu, 21 Feb 2019 14:08:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net] net: avoid false positives in untrusted gso
 validation

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Mon, 18 Feb 2019 23:37:12 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> GSO packets with vnet_hdr must conform to a small set of gso_types.
> The below commit uses flow dissection to drop packets that do not.
> 
> But it has false positives when the skb is not fully initialized.
> Dissection needs skb->protocol and skb->network_header.
> 
> Infer skb->protocol from gso_type as the two must agree.
> SKB_GSO_UDP can use both ipv4 and ipv6, so try both.
> 
> Exclude callers for which network header offset is not known.
> 
> Fixes: d5be7f632bad ("net: validate untrusted gso packets without csum offload")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied and queued up for -stable, thanks.