netdev - Re: [PATCH] net: marvell: mvneta: fix DMA debug warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190220.195712.291935128844235315.davem@davemloft.net>
Date:   Wed, 20 Feb 2019 19:57:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     thomas.petazzoni@...tlin.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: marvell: mvneta: fix DMA debug warning

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Fri, 15 Feb 2019 13:55:47 +0000

> Booting 4.20 on SolidRun Clearfog issues this warning with DMA API
> debug enabled:
 ...
> This appears to be caused by mvneta_rx_hwbm() calling
> dma_sync_single_range_for_cpu() with the wrong struct device pointer,
> as the buffer manager device pointer is used to map and unmap the
> buffer.  Fix this.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> ---
> Please check that this is the correct fix.

This makes it consistent with the other DMA calls in the hwbm
code paths, so on that basis I'm applying this and queueing it
up for -stable.

Thanks.