netdev - Re: [Bridge] [PATCH net] net: bridge: remove ipv6 zero address check in mcast queries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Feb 2019 20:49:04 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     Linus Lüssing <linus.luessing@...3.blue>,
        netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        bridge@...ts.linux-foundation.org, davem@...emloft.net,
        yinxu@...hat.com,
        Sebastian Gottschall <s.gottschall@...media-net.de>
Subject: Re: [Bridge] [PATCH net] net: bridge: remove ipv6 zero address check
 in mcast queries

On Fri, Feb 22, 2019 at 01:16:53PM +0200, Nikolay Aleksandrov wrote:
> > 
> > For consistency with other vendors and rfc, I would prefer to remove zero address election.
> > For compatibility with previous users, I'm also OK to revert it.
> > > Regards
> > Hangbin
> > 
> 
> Hi,
> In this case I'd suggest the following course of action:
>  - For -net/-stable revert the change since backporting new options is a
>    no-go and we need to restore the bridge state
>  - After -net is merged in net-next, for net-next if you'd like add it
>    as an option and also exclude it from elections when the option is
>    enabled (for example something like multicast_nonzero_src_querier).
>    Just please use the boolopt api and don't add new fields/attr ids.
>    Obviously by default this option will be off to be backwards
>    compatible and avoid surprise mcast flood.
> 
> Or just leave it reverted. :)

This makes sense to me. Thanks for your suggestions.

Regards
Hangbin