netdev - Re: [PATCH net-next 2/4] net: dsa: mv88e6xxx: Fix -Wformat-security warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222131425.GH5653@lunn.ch>
Date:   Fri, 22 Feb 2019 14:14:25 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Vivien Didelot <vivien.didelot@...il.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/4] net: dsa: mv88e6xxx: Fix -Wformat-security
 warnings

On Thu, Feb 21, 2019 at 08:09:27PM -0800, Florian Fainelli wrote:
> We are not specifying an explicit format argument but instead passing a
> string litteral which causes these two warnings to show up:
> 
> drivers/net/dsa/mv88e6xxx/chip.c: In function
> 'mv88e6xxx_irq_poll_setup':
> drivers/net/dsa/mv88e6xxx/chip.c:483:2: warning: format not a string
> literal and no format arguments [-Wformat-security]
>   chip->kworker = kthread_create_worker(0, dev_name(chip->dev));
>   ^~~~
> drivers/net/dsa/mv88e6xxx/ptp.c: In function 'mv88e6xxx_ptp_setup':
> drivers/net/dsa/mv88e6xxx/ptp.c:403:4: warning: format not a string
> literal and no format arguments [-Wformat-security]
>     dev_name(chip->dev));
>     ^~~~~~~~
>   LD [M]  drivers/net/dsa/mv88e6xxx/mv88e6xxx.o
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Hi Florian

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew