netdev - Re: linux-next: build warning after merge of the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e21bc598-fe9f-c988-bc8a-bc23b6d62a71@gmail.com>
Date:   Thu, 21 Feb 2019 17:10:41 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kees Cook <keescook@...omium.org>
Subject: Re: linux-next: build warning after merge of the net-next tree

On 2/21/19 5:06 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/net/ethernet/rocker/rocker_main.c: In function 'rocker_port_attr_set':
> drivers/net/ethernet/rocker/rocker_main.c:2083:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    err = rocker_world_port_attr_pre_bridge_flags_set(rocker_port,
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               attr->u.brport_flags,
>               ~~~~~~~~~~~~~~~~~~~~~
>               trans);
>               ~~~~~~
> drivers/net/ethernet/rocker/rocker_main.c:2086:2: note: here
>   case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
>   ^~~~
> 
> Introduced by commit
> 
>   93700458ff63 ("rocker: Check Handle PORT_PRE_BRIDGE_FLAGS")
> 
> I get this warning because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).

There is a missing break, my rebase went wrong with that, I will send a
fix shortly for that.
-- 
Florian