netdev - Re: [PATCH net-next] net: phy: let genphy_c45_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222175150.1cadc919@bootlin.com>
Date:   Fri, 22 Feb 2019 17:51:50 +0100
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: let genphy_c45_read_abilities also
 check aneg capability

Hello Heiner,

On Fri, 22 Feb 2019 08:23:04 +0100
Heiner Kallweit <hkallweit1@...il.com> wrote:

>When using genphy_c45_read_abilities() as get_features callback we
>also have to set the autoneg capability in phydev->supported.

>@@ -336,6 +336,17 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev)

This makes the helper not reading PMA-only registers, so the naming
isn't really relevant anymore, but that's a small detail.

Other than that,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Thanks,

Maxime