netdev - Re: [PATCH net] net: socket: add check for negative optlen in compat setsockopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Feb 2019 11:50:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jannh@...gle.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: socket: add check for negative optlen in
 compat setsockopt

From: Jann Horn <jannh@...gle.com>
Date: Wed, 20 Feb 2019 22:34:54 +0100

> __sys_setsockopt() already checks for `optlen < 0`. Add an equivalent check
> to the compat path for robustness. This has to be `> INT_MAX` instead of
> `< 0` because the signedness of `optlen` is different here.
> 
> Signed-off-by: Jann Horn <jannh@...gle.com>

Applied and queued up for -stable, thanks Jann.