netdev - Re: [PATCH net-next v2 1/5] net: devlink: turn devlink into a built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02c664c7-ee88-53d0-8583-b9c24eca7269@gmail.com>
Date:   Fri, 22 Feb 2019 12:07:19 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net,
        jiri@...nulli.us
Cc:     mkubecek@...e.cz, andrew@...n.ch, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v2 1/5] net: devlink: turn devlink into a
 built-in

On 2/22/19 11:54 AM, Jakub Kicinski wrote:
> Being able to build devlink as a module causes growing pains.
> First all drivers had to add a meta dependency to make sure
> they are not built in when devlink is built as a module.  Now
> we are struggling to invoke ethtool compat code reliably.
> 
> Make devlink code built-in, users can still not build it at
> all but the dynamically loadable module option is removed.

One use case I was potentially thinking about was that you have to load
devlink at some point to e.g.: recover your device from an initramfs,
and then you don't use devlink anymore so just you rmmod it and you have
switched to a different filesystem entirely (possibly on the network
that you just helped recover). That sounds like a corner case though so:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian