netdev - Re: [PATCH net-next v2 3/5] devlink: create a special NDO for getting the devlink instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222120951.4eb762f9@cakuba.netronome.com>
Date:   Fri, 22 Feb 2019 12:09:51 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     davem@...emloft.net, jiri@...nulli.us, mkubecek@...e.cz,
        andrew@...n.ch, netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v2 3/5] devlink: create a special NDO for
 getting the devlink instance

On Fri, 22 Feb 2019 12:04:07 -0800, Florian Fainelli wrote:
> On 2/22/19 11:54 AM, Jakub Kicinski wrote:
> > Instead of iterating over all devlink ports add a NDO which
> > will return the devlink instance from the driver.
> > 
> > v2: add the netdev_to_devlink() helper (Michal)
> > 
> > Suggested-by: Jiri Pirko <jiri@...nulli.us>
> > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> > ---  
> [snip]
> 
> > -	mutex_unlock(&devlink_mutex);
> > +	devlink = netdev_to_devlink(dev);
> > +	if (!devlink || !devlink->ops->info_get)
> > +		return;  
> 
> AFAICT devlink_create() allows one to specify a NULL ops argument (not
> that this makes sense), so probably need to add a check against
> devlink->ops here as well, unless we want to change devlink_create() to
> refuse a NULL ops pointer.

Oh, you're right!  devlink_nl_cmd_reload() seems to be missing that
check as well.  Let me respin quickly.

> Other than that:
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!