netdev - [PATCH] bpfilter: re-add header search paths to tools include to fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Feb 2019 12:23:19 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Song Liu <songliubraving@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Yonghong Song <yhs@...com>, linux-kernel@...r.kernel.org,
        Martin KaFai Lau <kafai@...com>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: [PATCH] bpfilter: re-add header search paths to tools include to fix build error

I thought header search paths to tools/include(/uapi) were unneeded,
but it looks like a build error occurs depending on the compiler.

Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
("bpfilter: fix a build err").

Apology for the breakage, and thanks to Guenter for reporting this.

Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
Reported-by: Guenter Roeck <linux@...ck-us.net>
Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
---

Guenter,

Sorry for bothering you, but
could you please test this with your compiler?

I am also using GCC 7.3, but my compiler cannot
reproduce the build error.


 net/bpfilter/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
index 5d6c776..854395f 100644
--- a/net/bpfilter/Makefile
+++ b/net/bpfilter/Makefile
@@ -5,6 +5,7 @@
 
 hostprogs-y := bpfilter_umh
 bpfilter_umh-objs := main.o
+KBUILD_HOSTCFLAGS += -Itools/include/ -Itools/include/uapi
 HOSTCC := $(CC)
 
 ifeq ($(CONFIG_BPFILTER_UMH), y)
-- 
2.7.4