netdev - Re: [PATCH net-next v2] ip_tunnel: Add dst_cache management lwtunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f228c250-ccde-d9e5-8072-8d5bee736f71@gmail.com>
Date:   Thu, 21 Feb 2019 22:39:04 -0500
From:   David Ahern <dsahern@...il.com>
To:     wenxu@...oud.cn, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] ip_tunnel: Add dst_cache management
 lwtunnel_state of ip tunnel

On 2/21/19 10:00 PM, wenxu@...oud.cn wrote:
> From: wenxu <wenxu@...oud.cn>
> 
> The lwtunnel_state is not init the dst_cache Which make the
> ip_md_tunnel_xmit can't use the dst_cache. It will lookup
> route table every packets.
> 
> Signed-off-by: wenxu <wenxu@...oud.cn>
> ---
>  net/ipv4/ip_tunnel_core.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
> index 9a0e67b..f91ef7a 100644
> --- a/net/ipv4/ip_tunnel_core.c
> +++ b/net/ipv4/ip_tunnel_core.c
> @@ -252,6 +252,12 @@ static int ip_tun_build_state(struct nlattr *attr,
>  
>  	tun_info = lwt_tun_info(new_state);
>  
> +	err = dst_cache_init(&tun_info->dst_cache, GFP_ATOMIC);

build_state is called with rtnl held. Unless I am missing something, you
don't need ATOMIC here.