netdev - [PATCH net v3] net: set static variable an initial value in atl2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222065723.193392-1-maowenan@huawei.com>
Date:   Fri, 22 Feb 2019 14:57:23 +0800
From:   Mao Wenan <maowenan@...wei.com>
To:     <kernel-janitors@...r.kernel.org>, <chris.snook@...il.com>,
        <jcliburn@...il.com>, <dan.carpenter@...cle.com>,
        <netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: [PATCH net v3] net: set static variable an initial value in atl2_probe()

cards_found is a static variable, but when it enters atl2_probe(),
cards_found is set to zero, the value is not consistent with last probe,
so next behavior is not our expect.

Signed-off-by: Mao Wenan <maowenan@...wei.com>
---
 v1->v2: change the subject from "net: drop pointless static qualifier in atl2_probe()"
 to "net: set static variable an initial value in atl2_probe()";
 keep 'static' for variable cards_found.  
 v2->v3: change patch description, and send patch to netdev mail list.

 drivers/net/ethernet/atheros/atlx/atl2.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
index bb41becb6609..31ff1e0d1baa 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -1335,13 +1335,11 @@ static int atl2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
 	struct net_device *netdev;
 	struct atl2_adapter *adapter;
-	static int cards_found;
+	static int cards_found = 0;
 	unsigned long mmio_start;
 	int mmio_len;
 	int err;
 
-	cards_found = 0;
-
 	err = pci_enable_device(pdev);
 	if (err)
 		return err;
-- 
2.20.1