netdev - RE: [PATCH 3/3] net: ethernet: add support for high speed mac and usxgmii pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 Feb 2019 06:24:46 +0000
From:   Parshuram Raju Thombare <pthombar@...ence.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rafal Ciepiela <rafalc@...ence.com>,
        Piotr Sroka <piotrs@...ence.com>, Jan Kotas <jank@...ence.com>
Subject: RE: [PATCH 3/3] net: ethernet: add support for high speed mac and
 usxgmii pcs

>>  	if (macb_is_gem(bp)) {
>> -		linkmode_copy(phydev->supported, PHY_GBIT_FEATURES);
>> -		if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
>> -
>	linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
>> -					 phydev->supported);
>> +		if (bp->caps & MACB_CAPS_HIGH_SPEED) {
>> +			linkmode_copy(phydev->supported,
>PHY_10GBIT_FEATURES);
>> +		} else {
>> +			u32 bitmask =
>ETHTOOL_LINK_MODE_2500baseT_Full_BIT;
>> +
>> +			linkmode_copy(phydev->supported,
>PHY_GBIT_FEATURES);
>> +			if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
>> +				linkmode_set_bit(bitmask, phydev->supported);
>> +		}
>
>Same issue again. Somebody could be using a 10G MAC with a 2.5G PHY.
>
>     Andrew
Hi Andrew,

Ok, I think this should have been logical AND. I will modify to use phy_set_max_speed() 
instead of directly copying linkmodes.

Regards,
Parshuram Thombare