netdev - Re: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190223090528.GL23561@mtr-leonro.mtl.com>
Date:   Sat, 23 Feb 2019 11:05:28 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Steve Wise <swise@...ngridcomputing.com>
Cc:     'David Ahern' <dsahern@...il.com>,
        'netdev' <netdev@...r.kernel.org>,
        'RDMA mailing list' <linux-rdma@...r.kernel.org>,
        'Stephen Hemminger' <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to
 separate file

On Thu, Feb 21, 2019 at 02:15:16PM -0600, Steve Wise wrote:
>
>
> > -----Original Message-----
> > From: linux-rdma-owner@...r.kernel.org <linux-rdma-
> > owner@...r.kernel.org> On Behalf Of Leon Romanovsky
> > Sent: Wednesday, February 20, 2019 1:21 AM
> > To: David Ahern <dsahern@...il.com>
> > Cc: Leon Romanovsky <leonro@...lanox.com>; netdev
> > <netdev@...r.kernel.org>; RDMA mailing list <linux-
> > rdma@...r.kernel.org>; Stephen Hemminger
> > <stephen@...workplumber.org>
> > Subject: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to
> > separate file
> >
> > From: Leon Romanovsky <leonro@...lanox.com>
> >
> > Logically separate resource PD logic to separate file,
> > in order to make PD specific logic self-contained.
> >
> > Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> > ---
>
> Why does it need to be self contained?

The main res.c file was so large that at least for me wasn't clear
how and what to refactor. Such separation allowed me to start code
cleanup by identification of duplicate places.

>
> Reviewed-by: Steve Wise <swise@...ngridcomputing.com>
>
>

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)