netdev - Re: [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for name and value separately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 24 Feb 2019 08:07:38 +0000
From:   Aya Levin <ayal@...lanox.com>
To:     Jiri Pirko <jiri@...nulli.us>
CC:     David Ahern <dsahern@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>
Subject: Re: [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for
 name and value separately


On 2/21/2019 4:08 PM, Jiri Pirko wrote:
> Thu, Feb 21, 2019 at 02:42:40PM CET, ayal@...lanox.com wrote:
>> Add a new helper functions which outputs only values (without name
>> label) for different types: boolean, uint, uint64, string and binary.
>> In addition add a helper function which prints only the name label.
>>
>> Signed-off-by: Aya Levin <ayal@...lanox.com>
>> Reviewed-by: Moshe Shemesh <moshe@...lanox.com>
>> ---
>> devlink/devlink.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 65 insertions(+), 1 deletion(-)
>>
>> diff --git a/devlink/devlink.c b/devlink/devlink.c
>> index b073ae020d52..5d69c4f24f29 100644
>> --- a/devlink/devlink.c
>> +++ b/devlink/devlink.c
>> @@ -1588,7 +1588,6 @@ static void pr_out_port_handle_end(struct dl *dl)
>> 		pr_out("\n");
>> }
>>
>> -
> 
> Please avoid changes like this.
Thanks,
Will fix in next version
> 
> 
> [...]
>