netdev - Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ3xEMg8_sFBsm_NXFsd=J02KncYENfiKUWPNHW2zgvKy9GKzA@mail.gmail.com>
Date:   Sun, 24 Feb 2019 11:23:42 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Tonghao Zhang <xiangxia.m.yue@...il.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when
 decapsulation offload not supported

On Sat, Feb 23, 2019 at 9:58 AM Tonghao Zhang <xiangxia.m.yue@...il.com> wrote:
> On Fri, Feb 22, 2019 at 5:07 PM Or Gerlitz <gerlitz.or@...il.com> wrote:
> > On Fri, Feb 22, 2019 at 9:49 AM Tonghao Zhang <xiangxia.m.yue@...il.com> wrote:
> > > On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz <gerlitz.or@...il.com> wrote:
> > > > On Thu, Feb 21, 2019 at 3:42 PM <xiangxia.m.yue@...il.com> wrote:
> > > > >
> > > > > From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> > > > >
> > > > > If we try to offload decapsulation actions to VFs hw, we get the log [1].
> > > >
> > > > but the switching was on the tunnel  type (if (tunnel_type == [...]) -
> > > Yes, but we try to offload tc flow to VF device. For example
> > > the  p2p1_0 is VF, but not rep


>> so this should go to the nic and not esw tc offload code path in en_tc.c

> nic and esw will call parse_cls_flower() to parse the flower flows,
> and more information is shown as below.

ok, got you. We err on the match parsing stage, this is relatively
new.. up to 5.0
we were erring only on the  action parsing stage. The patch seems fine, it would
be good to modify  mlx5e_netdev_kind() to return "unkown" and not the
empty string
("") when the netdev doesn't have a kind assigned (can do this in this patch).