netdev - Re: [PATCH net-next] net: phy: check PMAPMD link status only in genphy_c45_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190224.174337.1452333811738028062.davem@davemloft.net>
Date:   Sun, 24 Feb 2019 17:43:37 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: check PMAPMD link status only in
 genphy_c45_read_link

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 22 Feb 2019 22:59:38 +0100

> The current code reports a link as up if all devices (except a few
> blacklisted ones) report the link as up. This breaks Aquantia AQCS109
> for lower speeds because on this PHY the PCS link status reflects a
> 10G link only. For Marvell there's a similar issue, therefore PHYXS
> device isn't checked.
> 
> There may be more PHYs where depending on the mode the link status
> of only selected devices is relevant.
> 
> For now it seems to be sufficient to check the link status of the
> PMAPMD device only. Leave the loop in the code to be prepared in
> case we have to add functionality to check more than one device,
> depending on the mode.
> 
> Successfully tested on a board with an AQCS109.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.