netdev - Re: [PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190225150453.GA16245@Inspiron-3521>
Date:   Mon, 25 Feb 2019 20:34:53 +0530
From:   Leslie Monis <lesliemonis@...il.com>
To:     Dave Taht <dave@...t.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/7] net: sched: pie: align PIE
 implementation with RFC 8033

On Mon, Feb 25, 2019 at 06:11:25AM -0800, Dave Taht wrote:
> Jamal Hadi Salim <jhs@...atatu.com> writes:
> 
> > On 2019-02-25 8:43 a.m., Jamal Hadi Salim wrote:
> >> On 2019-02-25 5:20 a.m., Leslie Monis wrote:
> >>> The current implementation of the PIE queuing discipline is
> >>> according to the
> >>> IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and
> >>> the paper
> >>> [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem].
> >>> However, a lot of necessary modifications and enhancements have
> >>> been proposed
> >>> in RFC 8033, which have not yet been incorporated in the source
> >>> code of Linux.
> >>> This patch series helps in achieving the same.
> >>>
> >>> Performance tests carried out using Flent [https://flent.org/]
> >>>
> >>
> >> +Cc the authors of PIE to double check these values.
> >> Please respond (it is how open source works!) and N/ACK
> >
> > Great. Bouncing addresses.
> > D. Taht - can you look at this?
> 
> Whose addresses are bouncing? The folk that did pie originally were
> mostly contractors and long ago moved on to other things.
> 
> My taht.net address tends to bounce to vger as I long ago mandated
> starttls on all email transactions which is why I use my gmail account
> for postings there. I keep hoping that one day vger will support
> starttls... posting it here as I'm an optimist. I wasn't expecting to be
> cc'd on this submittal....
> 
> Pie seems to be mostly an abandoned CISCO effort outside of docsis-pie,
> at least at the moment. I've heard not a peep from them in years.
> (fq_codel seems to have mostly "won" in our world)
> 
> I did review all these changes when they went by in v1, and aside from
> the ecn mistake ending up in the final RFC when I wasn't looking[1],
> approve of these changes to sch_pie to make it compliant with the rfc,
> finally.
> 
> [1] We proposed refining pie's ecn handling here:
> 
> https://github.com/gautamramk/FQ-PIE-for-Linux-Kernel/issues/2
> 
> Anyway:
> 
> Acked-by: Dave Taht <dave.taht@...il.com>
> 

Hi Dave,

For now we would just like to make the PIE implementation meet the 
standards as expressed by the RFC. As ECN handling is outside the 
scope of the RFC we can consider refinements to it in the code later.

Thanks,
Leslie