netdev - Re: [PATCH net] net: sched: act_tunnel_key: fix NULL pointer dereference during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190225.101659.79848785664331466.davem@davemloft.net>
Date:   Mon, 25 Feb 2019 10:16:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, dcaratti@...hat.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, wenxu@...oud.cn,
        roid@...lanox.com
Subject: Re: [PATCH net] net: sched: act_tunnel_key: fix NULL pointer
 dereference during init

From: Vlad Buslov <vladbu@...lanox.com>
Date: Mon, 25 Feb 2019 17:28:27 +0200

> Metadata pointer is only initialized for action TCA_TUNNEL_KEY_ACT_SET, but
> it is unconditionally dereferenced in tunnel_key_init() error handler.
> Verify that metadata pointer is not NULL before dereferencing it in
> tunnel_key_init error handling code.
> 
> Fixes: ee28bb56ac5b ("net/sched: fix memory leak in act_tunnel_key_init()")
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Applied and queued up for -stable.