netdev - Re: [PATCH] tun: fix blocking read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190225.102548.247362521843809607.davem@davemloft.net>
Date:   Mon, 25 Feb 2019 10:25:48 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     mail@...urcelik.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tun: fix blocking read

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 25 Feb 2019 07:53:08 -0800

> 
> 
> On 02/24/2019 10:12 PM, David Miller wrote:
>> From: Timur Celik <mail@...urcelik.de>
>> Date: Sat, 23 Feb 2019 12:53:13 +0100
>> 
>>> This patch moves setting of the current state into the loop. Otherwise
>>> the task may end up in a busy wait loop if none of the break conditions
>>> are met.
>>>
>>> Signed-off-by: Timur Celik <mail@...urcelik.de>
>> 
>> Applied and queued up for -stable, thanks.
>> 
> 
> First part of the patch was matching the changelog, however
> the second change was not really needed, or should have used 
> 
> __set_current_state(TASK_RUNNING);

Timur, please followup.