netdev - Re: [PATCH net] ipv4: Add ICMPv6 support when parse route ipproto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <212750de-2d6a-ebb9-5079-bacf234f6cf6@gmail.com>
Date:   Mon, 25 Feb 2019 11:46:51 -0700
From:   David Ahern <dsahern@...il.com>
To:     Sabrina Dubroca <sd@...asysnail.net>,
        Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Roopa Prabhu <roopa@...ulusnetworks.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] ipv4: Add ICMPv6 support when parse route ipproto

On 2/25/19 4:14 AM, Sabrina Dubroca wrote:
> 2019-02-25, 15:47:00 +0800, Hangbin Liu wrote:
>> @@ -14,6 +15,7 @@ int rtm_getroute_parse_ip_proto(struct nlattr *attr, u8 *ip_proto,
>>  	case IPPROTO_TCP:
>>  	case IPPROTO_UDP:
>>  	case IPPROTO_ICMP:
>> +	case IPPROTO_ICMPV6:
> 
> Is IPPROTO_ICMPV6 supposed to be valid in the IPv4 code path calling
> this function? 

no. I do not see how that makes sense.