[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190225202653.4dbe00c2@carbon>
Date: Mon, 25 Feb 2019 20:26:53 +0100
From: Jesper Dangaard Brouer <brouer@...hat.com>
To: Joe Perches <joe@...ches.com>
Cc: Daniel Borkmann <daniel@...earbox.net>,
Jakub Kicinski <jakub.kicinski@...ronome.com>,
syzbot <syzbot+8218a8a0ff60c19b8eae@...kaller.appspotmail.com>,
ast@...nel.org, christian@...uner.io, davem@...emloft.net,
dsahern@...il.com, hawk@...nel.org, idosch@...lanox.com,
john.fastabend@...il.com, kafai@...com, ktkhai@...tuozzo.com,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
petrm@...lanox.com, roopa@...ulusnetworks.com,
songliubraving@...com, syzkaller-bugs@...glegroups.com,
xdp-newbies@...r.kernel.org, yhs@...com, brouer@...hat.com
Subject: Re: INFO: task hung in rtnetlink_rcv_msg
On Mon, 25 Feb 2019 08:55:40 -0800
Joe Perches <joe@...ches.com> wrote:
> On Mon, 2019-02-25 at 09:39 +0100, Jesper Dangaard Brouer wrote:
> > On Sat, 23 Feb 2019 01:47:00 +0100
> > Daniel Borkmann <daniel@...earbox.net> wrote:
> >
> > > On 02/22/2019 10:45 PM, Jakub Kicinski wrote:
> > > > On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote:
> > > > > On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote:
> > > > > > Hi!
> > > > > >
> > > > > > Seems like something funny is going on with get_maintainer.pl since XDP
> > > > > > entry got added. We seem to have been CCed on:
> > > > >
> > > > > I suggest removing the MAINTAINERS line with
> > > > >
> > > > > K: xdp
> > > > >
> > > > > as xdp is a pretty generic file/patch content
> > > > > regex match for the K: type
> > > > >
> > > > > $ git grep --name-only xdp | wc -l
> > > > > 236
> >
> > I'm unsure how K: works, but you grep definitely selects some wrong files.
> >
> > I tried with "xdp_":
> > git grep --name-only xdp_
> >
> > That does catch all the driver that have XDP support, which is the
> > point of the exercise (to catch drivers).
> >
> > It does contain a couple of false-positives:
> > drivers/net/ethernet/neterion/vxge/vxge-traffic.c
> > drivers/thunderbolt/tb_msgs.h
> > drivers/thunderbolt/xdomain.c
> > sound/soc/codecs/rt5670.c
> >
> > Via the pattern '[^a-z]xdp_' I'm only left with the thunderbolt
> > false-positive, as it have a data struct's called tb_xdp_*.
>
> Then it's probably better to use
>
> K: \Wxdp_
>
> and if XDP_ is also to be matched, maybe
>
> K: (?i:\Wxdp_)
>
The last one seems to be the best at matching the relevant files :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
Powered by blists - more mailing lists