netdev - Re: [PATCH] net: phy: Micrel KSZ8061: link failure after cable connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190226140608.GF3809@lunn.ch>
Date:   Tue, 26 Feb 2019 15:06:08 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Rajasingh Thavamani <T.Rajasingh@...disgyr.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: Micrel KSZ8061: link failure after cable
 connect

On Tue, Feb 26, 2019 at 01:45:06PM +0530, Rajasingh Thavamani wrote:
> With Micrel KSZ8061 PHY, the link may occasionally not come up after
> Ethernet cable connect. The vendor's (Microchip, former Micrel) errata
> sheet 80000688A.pdf descripes the problem and possible workarounds in
> detail, see below.
> The batch implements workaround 1, which permanently fixes the issue.
 
...

> PLAN
> This errata will not be corrected in the future revision.
> 
> Signed-off-by: Rajasingh Thavamani <T.Rajasingh@...disgyr.com>

We have been here before:

https://lkml.org/lkml/2018/11/23/466

At that time, the patch was from Alexander Onnasch, and has his
signed-off-by. Now it only has your SOB. It probably should have
both. My reviewed-by has gone missing. And this is version 3? And in
the comments i also included a Fixed: tag, which should be added.

Please submit a v4 with all these issues fixed.

Thanks
       Andrew