netdev - Re: [PATCH] tcp: fix __tcp_transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <353dd5fd-7364-4454-6d75-342ebce7c1c5@gmail.com>
Date:   Tue, 26 Feb 2019 07:11:52 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Geliang Tang <geliangtang@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tcp: fix __tcp_transmit_skb's comment text



On 02/26/2019 12:41 AM, Geliang Tang wrote:
> The function name tcp_do_sendmsg has been renamed. But it still
> appears in __tcp_transmit_skb's comment text. This patch changes
> it to tcp_sendmsg_locked.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  net/ipv4/tcp_output.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index e72aa0ff5785..67a43b966b8a 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -1003,7 +1003,7 @@ static void tcp_update_skb_after_send(struct sock *sk, struct sk_buff *skb,
>  }
>  
>  /* This routine actually transmits TCP packets queued in by
> - * tcp_do_sendmsg().  This is used by both the initial
> + * tcp_sendmsg_locked().  This is used by both the initial
>   * transmission and possible later retransmissions.
>   * All SKB's seen here are completely headerless.  It is our
>   * job to build the TCP header, and pass the packet down to
> 

Not sure your patch helps, packets can also be put in write queue
by many different functions, including tcp_sendmsg_locked().