netdev - Re: [PATCH net-next v4 0/6] devlink: make ethtool compat reliable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190226.085009.1852402564933343298.davem@davemloft.net>
Date:   Tue, 26 Feb 2019 08:50:09 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     jiri@...nulli.us, mkubecek@...e.cz, andrew@...n.ch,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v4 0/6] devlink: make ethtool compat reliable

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Mon, 25 Feb 2019 19:34:01 -0800

> This is a follow up to the series which added device flash
> updates via devlink. I went with the approach of adding a
> new NDO in the end. It seems to end up looking cleaner.
> 
> First patch removes the option to build devlink as a module.
> Users can still decide to not build it, but the module option
> ends up not being worth the maintenance cost.
> 
> Next two patches add a NDO which can be used to ask the driver
> to return a devlink instance associated with a given netdev,
> instead of iterating over devlink ports. Drivers which implement
> this NDO must take into account the potential impact on the
> visibility of the devlink instance.
> 
> With the new NDO in place we can remove NFP ethtool flash update
> code.
> 
> Fifth patch makes sure we hold a reference to dev while
> callbacks are active.
> 
> Last but not least the NULL-check of devlink->ops is moved
> to instance allocation time.
> 
> Last but not least missing checks for devlink->ops are added.
> There is currently no driver registering devlink without ops,
> so can just fix this in -next.
> 
> v2 (Michal): add netdev_to_devlink() in patch 3.
> v3 (Florian):
>  - add missing checks for devlink->ops;
>  - move locking/holding into devlink_compat_ functions.
> v4 (Jiri):
>  - hold devlink_mutex around callbacks (patch 2);
>  - require non-NULL ops (patch 6).

Series applied, thanks Jakub.