netdev - Re: [net-next 01/16] ice: Mark extack argument as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Feb 2019 16:36:22 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, Bruce Allan <bruce.w.allan@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: [net-next 01/16] ice: Mark extack argument as __always_unused

On Mon, 25 Feb 2019 10:42:51 -0800
Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:

> From: Bruce Allan <bruce.w.allan@...el.com>
> 
> Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()") in
> net-next added an extended parameter to the .ndo_fdb_add op and changed
> ice_fdb_add() accordingly. Update the function header and add the
> __always_unused attribute to the new parameter to avoid -Wunused-parameter
> warnings.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 48f033928aa2..9d266d754445 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -2435,11 +2435,12 @@ static void ice_set_rx_mode(struct net_device *netdev)
>   * @addr: the MAC address entry being added
>   * @vid: VLAN id
>   * @flags: instructions from stack about fdb operation
> + * @extack: netlink extended ack
>   */
> -static int ice_fdb_add(struct ndmsg *ndm, struct nlattr __always_unused *tb[],
> -		       struct net_device *dev, const unsigned char *addr,
> -		       u16 vid, u16 flags,
> -		       struct netlink_ext_ack *extack)
> +static int
> +ice_fdb_add(struct ndmsg *ndm, struct nlattr __always_unused *tb[],
> +	    struct net_device *dev, const unsigned char *addr, u16 vid,
> +	    u16 flags, struct netlink_ext_ack __always_unused *extack)
>  {
>  	int err;
>  

There are several log messages in ice_fdb_add, why don't you convert those
to be user friendly and use the extended ack mechanism?