netdev - Re: [PATCH net] sit: use ipv6_mod_enabled to check if ipv6 is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da79cacd-c95d-6f52-109e-10273f7452b3@cumulusnetworks.com>
Date:   Mon, 25 Feb 2019 19:15:26 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org,
        Stefano Brivio <sbrivio@...hat.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] sit: use ipv6_mod_enabled to check if ipv6 is
 disabled

On 2/25/19 6:55 PM, Hangbin Liu wrote:
> Just as I said, this issue only occurs when IPv6 is disabled at boot time
> as there is no IPv6 route entry. Disable ipv6 on specific interface should
> not be affected(IPv6 route/fib has inited). So I think use ipv6_mod_enabled()
> would be more suitable in this scenario. Did I miss something?

>From a readability perspective the code path depends on whether ipv6 is
enabled on the device. I think it is better to leave that as it is.