netdev - Re: [PATCH net-next v4 6/6] devlink: require non-NULL ops for devlink instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <204209fc-55e5-605c-da98-76ba9d5a5160@gmail.com>
Date:   Mon, 25 Feb 2019 20:29:27 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net,
        jiri@...nulli.us
Cc:     mkubecek@...e.cz, andrew@...n.ch, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v4 6/6] devlink: require non-NULL ops for devlink
 instances



On 2/25/2019 7:34 PM, Jakub Kicinski wrote:
> Commit 76726ccb7f46 ("devlink: add flash update command") and
> commit 2d8dc5bbf4e7 ("devlink: Add support for reload")
> access devlink ops without NULL-checking. There is, however, no
> driver which would pass in NULL ops, so let's just make that
> a requirement. Remove the now unnecessary NULL-checking.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian