netdev - Re: [PATCH net-next 1/2] vxlan: add extack support for create and changelink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUg6CrMz7i0UBYvqGmsewGV7rXQyhMOArtkQ-4qehA+PVw@mail.gmail.com>
Date:   Tue, 26 Feb 2019 17:05:17 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Petr Machata <petrm@...lanox.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dsa@...ulusnetworks.com" <dsa@...ulusnetworks.com>,
        "sd@...asysnail.net" <sd@...asysnail.net>,
        "johannes@...solutions.net" <johannes@...solutions.net>
Subject: Re: [PATCH net-next 1/2] vxlan: add extack support for create and changelink

On Tue, Feb 26, 2019 at 9:45 AM Petr Machata <petrm@...lanox.com> wrote:
>
>
> Roopa Prabhu <roopa@...ulusnetworks.com> writes:
>
> > On Tue, Feb 26, 2019 at 5:51 AM Petr Machata <petrm@...lanox.com> wrote:
> >>
> >> Many of the flags for which you call this don't actually have the else
> >> branch. However I suspect there are no good reasons not to allow
> >> resetting a flag.
> >>
> >> Reviewed-by: Petr Machata <petrm@...lanox.com>
> >
> > yes, correct, that was intentional.
> > also, I am not sure what is the best way to support reseting of a NLA_FLAG.
> > Absence of the flag attribute in the request cannot be the reason for
> > resetting or clearing the flag.
>
> Yeah, I was thinking about that. It looks like this would need a new set
> of u8 attributes :-(

yes, and thats unfortunate. We should keep an eye on future NLA_FLAG
attributes during review .