netdev - Re: [PATCH net-next 2/3] net: dsa: microchip: add KSZ9893 switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190227131438.GH3809@lunn.ch>
Date:   Wed, 27 Feb 2019 14:14:38 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Tristram.Ha@...rochip.com
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Pavel Machek <pavel@....cz>, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] net: dsa: microchip: add KSZ9893 switch
 support

>  static int ksz9477_phy_read16(struct dsa_switch *ds, int addr, int reg)
> @@ -353,7 +363,7 @@ static int ksz9477_phy_read16(struct dsa_switch *ds, int addr, int reg)
>  			val = 0x796d;
>  			break;
>  		case MII_PHYSID1:
> -			val = 0x0022;
> +			val = KSZ9477_ID_HI;
>  			break;
>  		case MII_PHYSID2:
>  			val = 0x1631;

Hi Tristram

This seems like an unrelated change, so should be in a separate
patch. And if you change PHYID1, it would also make sense to change
PHYID2 to a #define.


Please split the tagging changes into a patch of there own.

       Andrew