netdev - Re: [PATCH][net-next] ethtool: Use explicit designated initializers for .cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190227135159.GC29992@unicorn.suse.cz>
Date:   Wed, 27 Feb 2019 14:51:59 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Li RongQing <lirongqing@...du.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH][net-next] ethtool: Use explicit designated initializers
 for .cmd

On Wed, Feb 27, 2019 at 08:47:57PM +0800, Li RongQing wrote:
> Initialize the .cmd member by using a designated struct
> initializer. This fixes warning of missing field initializers,
> and makes code a little easier to read.
> 
> Signed-off-by: Li RongQing <lirongqing@...du.com>

Reviewed-by: Michal Kubecek <mkubecek@...e.cz>

> ---
>  net/core/ethtool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index 47558ffae423..d4918ffddda8 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -1717,7 +1717,7 @@ static noinline_for_stack int ethtool_set_channels(struct net_device *dev,
>  
>  static int ethtool_get_pauseparam(struct net_device *dev, void __user *useraddr)
>  {
> -	struct ethtool_pauseparam pauseparam = { ETHTOOL_GPAUSEPARAM };
> +	struct ethtool_pauseparam pauseparam = { .cmd = ETHTOOL_GPAUSEPARAM };
>  
>  	if (!dev->ethtool_ops->get_pauseparam)
>  		return -EOPNOTSUPP;
> @@ -2503,7 +2503,7 @@ static int set_phy_tunable(struct net_device *dev, void __user *useraddr)
>  
>  static int ethtool_get_fecparam(struct net_device *dev, void __user *useraddr)
>  {
> -	struct ethtool_fecparam fecparam = { ETHTOOL_GFECPARAM };
> +	struct ethtool_fecparam fecparam = { .cmd = ETHTOOL_GFECPARAM };
>  	int rc;
>  
>  	if (!dev->ethtool_ops->get_fecparam)
> -- 
> 2.16.2
>