netdev - Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42e71e1f-0a51-c517-5a93-b8d9b8c0fecf@mellanox.com>
Date:   Wed, 27 Feb 2019 14:05:02 +0000
From:   Roi Dayan <roid@...lanox.com>
To:     "xiangxia.m.yue@...il.com" <xiangxia.m.yue@...il.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        "gerlitz.or@...il.com" <gerlitz.or@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when
 allocating pedit action



On 26/02/2019 14:28, xiangxia.m.yue@...il.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> The capacity of FDB offloading and NIC offloading table are
> different, and when allocating the pedit actions, we should
> use the correct namespace type.
> 
> Fixes: c500c86b0c75d ("net/mlx5e: support for two independent packet edit actions")
> Cc: Pablo Neira Ayuso <pablo@...filter.org>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index 3a02b22..467ef9e 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
>  
>  	if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits ||
>  	    hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) {
> -		err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_KERNEL,
> +		err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_FDB,
>  					    parse_attr, hdrs, extack);
>  		if (err)
>  			return err;
> 

Reviewed-by: Roi Dayan <roid@...lanox.com>