netdev - Re: [PATCH net v3 2/2] selftests: pmtu: add explicit tests for PMTU exceptions cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <097dd04a-8bb1-7870-36a0-3ae5f071137f@gmail.com>
Date:   Wed, 27 Feb 2019 09:18:16 -0700
From:   David Ahern <dsahern@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Stefano Brivio <sbrivio@...hat.com>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH net v3 2/2] selftests: pmtu: add explicit tests for PMTU
 exceptions cleanup

On 2/25/19 8:08 AM, Paolo Abeni wrote:
> Add a couple of new tests, explicitly checking that the kernel
> timely releases PMTU exceptions on related device removal.
> This is mostly a regression test vs the issue fixed by
> commit f5b51fe804ec ("ipv6: route: purge exception on removal")
> 
> Only 2 new test cases have been added, instead of extending all
> the existing ones, because the reproducer requires executing
> several commands and would slow down too much the tests otherwise.
> 
> v2 -> v3:
>  - more cleanup, still from Stefano
> 
> v1 -> v2:
>  - several script cleanups, as suggested by Stefano
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  tools/testing/selftests/net/pmtu.sh | 68 ++++++++++++++++++++++++++++-
>  1 file changed, 67 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...il.com>

Thanks for adding the tests.