netdev - Re: [PATCH net] bnxt_en: Drop oversize TX packets to prevent errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Feb 2019 09:30:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     michael.chan@...adcom.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: Drop oversize TX packets to prevent
 errors.

From: Michael Chan <michael.chan@...adcom.com>
Date: Wed, 27 Feb 2019 03:58:53 -0500

> There have been reports of oversize UDP packets being sent to the
> driver to be transmitted, causing error conditions.  The issue is
> likely caused by the dst of the SKB switching between 'lo' with
> 64K MTU and the hardware device with a smaller MTU.  Patches are
> being proposed by Mahesh Bandewar <maheshb@...gle.com> to fix the
> issue.
> 
> In the meantime, add a quick length check in the driver to prevent
> the error.  The driver uses the TX packet size as index to look up an
> array to setup the TX BD.  The array is large enough to support all MTU
> sizes supported by the driver.  The oversize TX packet causes the
> driver to index beyond the array and put garbage values into the
> TX BD.  Add a simple check to prevent this.
> 
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> ---
> 
> David, I think this should be queued for stable as well.

Applied and queued up for -stable.

Thanks for following up on this Michael.