netdev - Re: [PATCH v1] net: dev: Use unsigned integer as an argument to left-shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Feb 2019 09:34:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andriy.shevchenko@...ux.intel.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v1] net: dev: Use unsigned integer as an argument to
 left-shift

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Wed, 27 Feb 2019 13:37:26 +0300

> 1 << 31 is Undefined Behaviour according to the C standard.
> Use U type modifier to avoid theoretical overflow.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied, thanks Andy.