netdev - Re: [PATCH net-next v3 0/8] net: Remove switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190227.124019.281722845670775310.davem@davemloft.net>
Date:   Wed, 27 Feb 2019 12:40:19 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, idosch@...lanox.com,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        bridge@...ts.linux-foundation.org, jiri@...lanox.com,
        andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [PATCH net-next v3 0/8] net: Remove switchdev_ops

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 27 Feb 2019 11:44:24 -0800

> This patch series completes the removal of the switchdev_ops by
> converting switchdev_port_attr_set() to use either the blocking
> (process) or non-blocking (atomic) notifier since we typically need to
> deal with both depending on where in the bridge code we get called from.
> 
> This was tested with the forwarding selftests and DSA hardware.
> 
> Ido, hopefully this captures your comments done on v1, if not, can you
> illustrate with some pseudo-code what you had in mind if that's okay?
> 
> Changes in v3:
> 
> - added Reviewed-by tags from Ido where relevant
> - added missing notifier_to_errno() in net/bridge/br_switchdev.c when
>   calling the atomic notifier for PRE_BRIDGE_FLAGS
> - kept mlxsw_sp_switchdev_init() in mlxsw/
> 
> Changes in v2:
> 
> - do not check for SWITCHDEV_F_DEFER when calling the blocking notifier
>   and instead directly call the atomic notifier from the single location
>   where this is required

Series applied, thanks Florian.

I'll push this out after my build tests complete.