netdev - Re: [PATCH net-next 1/1] net: sched: act_csum: Fix csum calc for tagged packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190227.215026.439681740594984441.davem@davemloft.net>
Date:   Wed, 27 Feb 2019 21:50:26 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     elibr@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, roid@...lanox.com, maord@...lanox.com
Subject: Re: [PATCH net-next 1/1] net: sched: act_csum: Fix csum calc for
 tagged packets

From: Eli Britstein <elibr@...lanox.com>
Date: Tue, 26 Feb 2019 09:57:34 +0000

> The csum calculation is different for IPv4/6. For VLAN packets,
> tc_skb_protocol returns the VLAN protocol rather than the packet's one
> (e.g. IPv4/6), so csum is not calculated. Furthermore, VLAN may not be
> stripped so csum is not calculated in this case too. Calculate the
> csum for those cases.
> 
> Fixes: d8b9605d2697 ("net: sched: fix skb->protocol use in case of accelerated vlan path")
> Signed-off-by: Eli Britstein <elibr@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied.