netdev - Re: [PATCH 0/8] net: ethernet: reduce calls to memset(,0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190228142514.GB18319@infradead.org>
Date:   Thu, 28 Feb 2019 06:25:14 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Robert Eshleman <bobbyeshleman@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] net: ethernet: reduce calls to memset(,0)

On Tue, Feb 26, 2019 at 10:04:54PM -0800, Robert Eshleman wrote:
> This patch series removes calls to memset(,0) that are
> redundant when used in conjunction with a zalloc call or
> by simple zero-assignment of structs.

NAK.  pci_zalloc_consistent is just as deprecated as
pci_alloc_consistent, and if you look at the implementation you'll
see that we actual zero the memory for both of them.

If you want to do some DMA-related busy work please just bulk convert
drivers from the PCI DMA API to the proper generic DMA API.  Bonus
points for automatіng that using a cocchinelle script.