netdev - Re: [PATCH v2] net: netem: fix skb length BUG_ON in __skb_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87c52b93-ef66-68f3-678b-2a29f678dbbf@gmail.com>
Date:   Thu, 28 Feb 2019 09:03:47 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Sheng Lan <lansheng@...wei.com>, stephen@...workplumber.org,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, netem@...ts.linux-foundation.org,
        xuhanbing@...wei.com, zhengshaoyu@...wei.com, jiqin.ji@...wei.com,
        liuzhiqiang26@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH v2] net: netem: fix skb length BUG_ON in __skb_to_sgvec



On 02/28/2019 02:47 AM, Sheng Lan wrote:
> From: Sheng Lan <lansheng@...wei.com>
> 
> It can be reproduced by following steps:
> 1. virtio_net NIC is configured with gso/tso on
> 2. configure nginx as http server with an index file bigger than 1M bytes
> 3. use tc netem to produce duplicate packets and delay:
>    tc qdisc add dev eth0 root netem delay 100ms 10ms 30% duplicate 90%
> 4. continually curl the nginx http server to get index file on client
> 5. BUG_ON is seen quickly
> 

...

> To fix it, netem returns NET_XMIT_SUCCESS to upper stack
> when it clones a duplicate packet.
> 
> Fixes: 35d889d1 ("sch_netem: fix skb leak in netem_enqueue()")
> Signed-off-by: Sheng Lan <lansheng@...wei.com>
> Reported-by: Qin Ji <jiqin.ji@...wei.com>
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> ---

Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Thanks.