netdev - Re: [PATCH net-next] cxgb4vf: Enter debugging mode if FW is inaccessible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190228.102749.523293065123206627.davem@davemloft.net>
Date:   Thu, 28 Feb 2019 10:27:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arjun@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, dt@...lsio.com, vishal@...lsio.com
Subject: Re: [PATCH net-next] cxgb4vf: Enter debugging mode if FW is
 inaccessible

From: Arjun Vynipadath <arjun@...lsio.com>
Date: Thu, 28 Feb 2019 15:33:16 +0530

> If we are not able to reach firmware, enter debugging mode that will
> help us to get adapter logs.
> 
> Signed-off-by: Arjun Vynipadath <arjun@...lsio.com>
> Signed-off-by: Vishal Kulkarni <vishal@...lsio.com>

Applied, however I will say:

> @@ -411,6 +411,7 @@ enum { /* adapter flags */
>  	USING_MSIX         = (1UL << 2),
>  	QUEUES_BOUND       = (1UL << 3),
>  	ROOT_NO_RELAXED_ORDERING = (1UL << 4),
> +	FW_OK              = (1UL << 5),
>  };

These macros are asking for conflicts in the global namespace and
could really use "CXGB4_XXX" prefixes.