netdev - Re: [PATCH] appletalk: Fix use-after-free in atalk_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Feb 2019 09:19:51 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <joe@...ches.com>, <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] appletalk: Fix use-after-free in atalk_proc_exit

On 2019/2/28 2:14, David Miller wrote:
> From: Yue Haibing <yuehaibing@...wei.com>
> Date: Wed, 27 Feb 2019 22:59:00 +0800
> 
>> @@ -1925,7 +1925,10 @@ static int __init atalk_init(void)
>>  
>>  	register_netdevice_notifier(&ddp_notifier);
>>  	aarp_proto_init();
>> -	atalk_proc_init();
>> +	rc = atalk_proc_init();
>> +	if (rc)
>> +		goto out;
>> +
>>  	atalk_register_sysctl();
>>  out:
> 
> This leaves the netdevice notifier registered etc.  You need to add a proper
> error cleanup code path.

Oh, yes, I will do it.

Thanks!

> 
> .
>